Author Topic: BetterTransfer : UI upgrade & Transfer cargo/crew/fighters - v1.12 (07 mar 2017)  (Read 27030 times)

Salminar

  • Jr. Member
  • **
  • Status:
    Offline
    Posts:
    94
    • View Profile
Can you give me a bit more informations?

Cause i tried both versions and both are working just fine on my computer. I'm waiting for a tester to look at this too when he have time, but is a bit busy.

Since the bug don't happen on my computer i need more details. Can you please asign the console to a key in your keybindings and look what the console says when you have the error?



Wilponderoci

  • Full Member
  • ***
  • Status:
    Offline
    Posts:
    203
  • one fish two fists
    • View Profile
ok so this is the error im getting...

Code: [Select]
could not execute function 'onShowWindow' in "data/scripts/entity/transfercrewgoods.lua":data/scripts/entity/transfercrewgoods.lua:475: attempt to index field '?' (a nil value)
stack traceback:
          data/scripts/entity/transfercrewgoods.lua:475: in function 'updateData'
          data/scripts/entity/transfercrewgoods.lua:802  in function <data/scripts/entity/transfercrewgoods.lua:801>

Setting script "data/scripts/entity/transfercrewgoods.lua to invalid.

Hope that helps...

I am using several mods but none that touch any of these files as far as i can tell. The UI come up and everything seems to work but when I click on the UI it just wont work. Then the error and file set to invalid
« Last Edit: March 14, 2017, 01:57:43 AM by Wilponderoci »
“Everything that irritates us about others can lead us to an understanding of ourselves.”



Salminar

  • Jr. Member
  • **
  • Status:
    Offline
    Posts:
    94
    • View Profile
Ok, look like there is an issue when you don't have fighter hangar on your ship.

I'll work on that and fix it.
« Last Edit: March 14, 2017, 09:04:58 AM by Salminar »



Wilponderoci

  • Full Member
  • ***
  • Status:
    Offline
    Posts:
    203
  • one fish two fists
    • View Profile
I found an abandoned ship, turned it into a miner and put a hanger on it. Went to transfer the mining fighters over to it.

same error....
“Everything that irritates us about others can lead us to an understanding of ourselves.”



Salminar

  • Jr. Member
  • **
  • Status:
    Offline
    Posts:
    94
    • View Profile
Really strange line 475 is for fighters display. Are you using vanilla or convenient? I assumed it was vanilla version.

And are you using the beta or normal branch of the game?



Wilponderoci

  • Full Member
  • ***
  • Status:
    Offline
    Posts:
    203
  • one fish two fists
    • View Profile
Im using beta branch 7633 /vanillatransfer
« Last Edit: March 15, 2017, 01:09:59 PM by Wilponderoci »
“Everything that irritates us about others can lead us to an understanding of ourselves.”



SirTiller

  • Newbie
  • *
  • Status:
    Offline
    Posts:
    1
    • View Profile
Hi,
unfortunatly i did something wrong.  :(
I copied the code, opened my transfergoodcrew.lua, mark all, deleted all, paste the new. Save. Started Avorion. Entered my Galaxie.
Drove to a station. UI is looks nice, but nothing happens. Neither if i tried to move cargo with the arrows nor with numbers.

Any hints?



Salminar

  • Jr. Member
  • **
  • Status:
    Offline
    Posts:
    94
    • View Profile
Well maybe someone will be able to send you the original file. Always do a backup for any mode and drag and drop my file in the good folder.

As if you have a bug, i really don't know, there are reports that it don't work, while on my computer all run absolutly perfectly.

The other tester seem to be busy and haven't tested anything so far. So i'm a bit looking for a needle in my garden.

I want to find what is the problem, but so far i can't with what i know. This and don't have much time to make many tests.

And i have many downloads but not much reports, don't know if it works only for me, for many people but a few. I really don't have much clues so far to figure what is wrong. I'd love to know if it works at all on someone else than me.
« Last Edit: March 16, 2017, 07:26:20 PM by Salminar »



Wilponderoci

  • Full Member
  • ***
  • Status:
    Offline
    Posts:
    203
  • one fish two fists
    • View Profile
I appreciate your work and if there is anything I can do to help provide a better report or understanding of this issue please let me know.

The mod looks wonderful and I would really really love to be able to transfer fighters.

Anyone have any clues?
“Everything that irritates us about others can lead us to an understanding of ourselves.”



Salminar

  • Jr. Member
  • **
  • Status:
    Offline
    Posts:
    94
    • View Profile
I did some testing with my friend.
So it works on his computer, on both normal and beta version. So it don't really help for your issue.
But looking for what was wrong, we came to another bug i'll have to investigate.

Anyway, with issues i had with him installing the mod, i'll ask a few more things.
If you are on windows 7 and what is the size of the file?
And maybe try to download it again and install it.

And lastly if the reinstalle didn't solved anything, could you open the file installed on your directory with an editor like notepad++ and tell me what is written on the line 475.

I know it's a bit boring but need to go step by step.



Wilponderoci

  • Full Member
  • ***
  • Status:
    Offline
    Posts:
    203
  • one fish two fists
    • View Profile
Sure thing!

Size of file is 30,282

I have re-downloaded the file for yet a 3rd time and compared them just to be sure

They are Identical... I am using Beyond Compare utility to make it absolutely certain. 

Line 475
Code: [Select]
findex = i*12+j+1
I have re-installed the file and run it again from github.

Now getting....

Code: [Select]
could not execute function 'onShowWindow' in "data/scripts/entity/transfercrewgoods.lua":data/scripts/entity/transfercrewgoods.lua:500: attempt to index field '?' (a nil value)
stack traceback:
          data/scripts/entity/transfercrewgoods.lua:500: in function 'updateData'
          data/scripts/entity/transfercrewgoods.lua:802  in function <data/scripts/entity/transfercrewgoods.lua:801>
Setting script "data/scripts/entity/transfercrewgoods.lua to invalid.

Line 500
Code: [Select]
   selfFighters[findex].pict.visible = false

Again the ships I am trying to transfer between one has a hanger one does not.

I have decided to upload the ships for you to try.

Autosave207 is my main ship. "Feck"

Fabulator is a Super maneuverable fighter/support ship

sQIbbLeS is my utility ship and has Hangers on her.   

They are zipped bc "Feck" is over 192kb (shes a wee beastie)
and I figured I would just zip them all for consistencies sake.

I have also included a dropbox link to my Scripts folder which includes the mods I am using.


Transport Permit
Detailed Turret Tooltips
Pirate Warlord, Dockbuilding, Better Shipyards
Avorion Commands package
Clean sector
Turret Fatory Seed Entry
Findstation
Salvage Command




Enjoy


I hope this is helpful
« Last Edit: March 17, 2017, 04:17:50 PM by Wilponderoci »
“Everything that irritates us about others can lead us to an understanding of ourselves.”



Salminar

  • Jr. Member
  • **
  • Status:
    Offline
    Posts:
    94
    • View Profile
Alright this helped me a lot this time.

That's trange the error is not on the same line anymore. Really seem like there is a wrong use of the index. I'll check for this later tonight.



Wilponderoci

  • Full Member
  • ***
  • Status:
    Offline
    Posts:
    203
  • one fish two fists
    • View Profile
:)

Im glad I can help!

 ;)

 8)
“Everything that irritates us about others can lead us to an understanding of ourselves.”



infal

  • Jr. Member
  • **
  • Status:
    Offline
    Posts:
    50
    • View Profile
Again the ships I am trying to transfer between one has a hanger one does not.

Is that even possible?
If you go to Profile->Forum Profile there is an option to enter your ICQ number! Pretty rad... if this were 1995!



Wilponderoci

  • Full Member
  • ***
  • Status:
    Offline
    Posts:
    203
  • one fish two fists
    • View Profile
Is that even possible?

 just trying to transfer crew mate :)
 or cargo...

Both fail.
“Everything that irritates us about others can lead us to an understanding of ourselves.”